Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TCP Transport Rewrite #946

Merged
merged 9 commits into from
Aug 14, 2018
Merged

TCP Transport Rewrite #946

merged 9 commits into from
Aug 14, 2018

Commits on Jul 3, 2018

  1. Rewrite TCP transport using CFNetwork API

    @shoamano83
    shoamano83 committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    5fc4e5b View commit details
    Browse the repository at this point in the history

  2. Add notification for TCP connection errors 

    If a TCP connection is refused or timed out, onError is notified
from the transport. Then an error will be delivered to the app
through NSNotification.
    @shoamano83
    shoamano83 committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    6bf797f View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2018

  1. Reflect review comments 

    - Rename an error enum
- Update / remove comments, pragmas and logs
- Resolve styling issues
    @shoamano83
    shoamano83 committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    72e4cb3 View commit details
    Browse the repository at this point in the history

  2. Reflect review comments 

    - Change receiveBufferSize to private
- Remove `default` case from switch statement
- Simplify some if statements
- Update logs
    @shoamano83
    shoamano83 committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    4aa7820 View commit details
    Browse the repository at this point in the history

  3. Reflect review comments 

    - Use NSAssert to check a flag that should be always false
    @shoamano83
    shoamano83 committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    3e34135 View commit details
    Browse the repository at this point in the history

  4. Move TestTCPServer into dedicated files

    @shoamano83
    shoamano83 committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    713f409 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into feature/rewrite_tcp_transport 

    Conflicts:
	SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @shoamano83
    shoamano83 committed Jul 27, 2018
    Configuration menu
    Copy the full SHA
    d4185a2 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2018

  1. Merge branch 'develop' into feature/rewrite_tcp_transport 

    Conflicts:
	SmartDeviceLink-iOS.xcodeproj/project.pbxproj
    @shoamano83
    shoamano83 committed Aug 2, 2018
    Configuration menu
    Copy the full SHA
    253d166 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Reflect review comment 

    - Add assertions in I/O callback methods
    @shoamano83
    shoamano83 committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    c1883ff View commit details
    Browse the repository at this point in the history