Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 4.1 compatibility issues #1551

Closed
bilal-alsharifi opened this issue Nov 6, 2020 · 0 comments
Closed

Gradle 4.1 compatibility issues #1551

bilal-alsharifi opened this issue Nov 6, 2020 · 0 comments
Projects

Comments

@bilal-alsharifi
Copy link
Contributor

Bug Report

The library doesn't compile if Gradle is updated to the current latest version (v 4.1). That is because the new Gradle removed versionName from BuildConfig and that is used in multiple places in the library. For example:

connection.setRequestProperty("User-Agent", "SmartDeviceLink/" + BuildConfig.VERSION_NAME);

string = BuildConfig.VERSION_NAME + ": " + string;

OS & Version Information
  • Android Version: N/A
  • SDL Android Version: 5.0.0
  • Testing Against: N/A
@joeljfischer joeljfischer added this to Contributions in 5.1.0 via automation Dec 10, 2020
@joeljfischer joeljfischer moved this from Contributions to Done in 5.1.0 Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.1.0
Done
Development

No branches or pull requests

2 participants