Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gradle 4.1 compatibility issue #1554

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Nov 6, 2020

Fixes #1551

This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Core Tests

To smoke test the PR: compile Hello Sdl Android, connect to Core, and make sure it connects successfully

Module tested against: Core 7.0

Summary

This PR:

  • Update Gradle plugin to the current latest version (4.1)
  • Add VERSION_NAME as a variable in build.gradle to force Gradle to add that var the BuildConfig so the Android library can use it

CLA

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1554 (178cd27) into hotfix/5.0.1 (e1ef1b4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##             hotfix/5.0.1    #1554      +/-   ##
==================================================
- Coverage           56.16%   56.14%   -0.03%     
+ Complexity           4995     4992       -3     
==================================================
  Files                 515      515              
  Lines               22274    22274              
  Branches             2768     2768              
==================================================
- Hits                12511    12506       -5     
- Misses               8831     8834       +3     
- Partials              932      934       +2     
Impacted Files Coverage Δ Complexity Δ
...tdevicelink/managers/audio/AudioDecoderCompat.java 70.00% <0.00%> (-3.34%) 3.00% <0.00%> (ø%)
...com/smartdevicelink/util/MediaStreamingStatus.java 63.80% <0.00%> (-0.96%) 17.00% <0.00%> (ø%)
...ink/managers/screen/BaseTextAndGraphicManager.java 63.75% <0.00%> (-0.42%) 50.00% <0.00%> (-2.00%)
...managers/screen/TextAndGraphicUpdateOperation.java 71.27% <0.00%> (-0.28%) 116.00% <0.00%> (-1.00%)

@bilal-alsharifi bilal-alsharifi changed the title [WIP] Fix Gradle 4.1 compatibility issue Fix Gradle 4.1 compatibility issue Nov 9, 2020
@RHenigan RHenigan merged commit 865eb35 into hotfix/5.0.1 Nov 9, 2020
@RHenigan RHenigan deleted the feature/gradle_4_1 branch November 9, 2020 21:51
@bilal-alsharifi bilal-alsharifi restored the feature/gradle_4_1 branch November 16, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants