Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string bug with Menu Cell #1623

Closed
RHenigan opened this issue Mar 4, 2021 · 1 comment
Closed

Empty string bug with Menu Cell #1623

RHenigan opened this issue Mar 4, 2021 · 1 comment
Labels
bug A defect in the library
Projects
5.1.0

Comments

@RHenigan
Copy link
Contributor

RHenigan commented Mar 4, 2021

Bug Report

If we set an empty string (i.e. "") for secondaryText or tertiaryText, when creating a MenuCell object we should send null instead. Otherwise core will reject the request

Reproduction Steps
  1. Define a MenuCell
  2. Set the secondaryText or tertiaryText property of MenuCell to an empty string (i.e. "")
  3. Launch App
Expected Behavior

the response from core should not present any error

Observed Behavior

The following error is logged:
E/BaseMenuManager: 5.0.0: Result: INVALID_DATA Info: RPC.msg_params.menuParams.secondaryText: Got string of size: 0, minimum allowed: 1
@RHenigan RHenigan mentioned this issue Mar 4, 2021
Merged
5 tasks
@jordynmackool jordynmackool added this to Contributions in 5.1.0 via automation Mar 12, 2021
@jordynmackool jordynmackool moved this from Contributions to Done in 5.1.0 Mar 12, 2021
@jordynmackool
Copy link
Contributor

closed via #1624

@jordynmackool jordynmackool added the bug A defect in the library label Mar 12, 2021
bilal-alsharifi added a commit that referenced this issue Apr 29, 2021
@bilal-alsharifi
Fix empty string bug with Menu Cell #1623
9506c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A defect in the library
Projects
No open projects
5.1.0
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RHenigan @jordynmackool