ScreenManager tries to upload images even if they are not supported (SDL 2.0)

[bilal-alsharifi]

Bug Report

It seems the ScreenManager tries to upload images on Sync 2 even if the dynamic images are not supported. That doesn't crash the app but it just sends RPCs when there is no need for that. It also logs some error messages like the following:

E/FileManager: 5.2.0: File named icon.png failed to upload. Max number of upload attempts reached.
E/FileManager: 5.2.0: File named image1.png failed to upload. Max number of upload attempts reached.
E/SoftButtonReplaceOperation: 5.2.0: Error uploading soft button artworks: [image1.png]
E/FileManager: 5.2.0: File named image2.png failed to upload. Max number of upload attempts reached.
E/SoftButtonReplaceOperation: 5.2.0: Error uploading soft button artworks: [image2.png]

The potential reason for the issue is that Sync 2 sends RegisterAppInterfaceResponse with the following values:

RegisterAppInterfaceResponse.displayCapabilities.graphicSupported = false
RegisterAppInterfaceResponse.softButtonCapabilities.imageSupported = true

The SoftButtonManager (and possibly other managers) depends on ImageSupported and thinks the images are supported when in reality they are not.

Reproduction Steps

1. Run SDL app on Sync 2 TDK
2. Use the SoftButtonManager to set buttons with images

Expected Behavior

Images for the buttons shouldn't be uploaded because the TDK doesn't support dynamic images.

Observed Behavior

SoftButtonManager tries to upload the images then fail

OS & Version Information

• Android Version: 11
• SDL Android Version: 5.2
• Testing Against: Sync 2

[JulianKast]

Fixed with #1811