Added crc to putfile #510
Merged
Added crc to putfile #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added getting n setters in Putfile, applied setter in RPCRequestFactory, CORRUPT_DATA to Result enum, added tests.
BrettyWhite
reviewed
May 11, 2017
| @@ -1003,7 +1004,8 @@ private void sendOnSystemRequestToUrl(OnSystemRequest msg) | |||
| putFile.setCorrelationID(POLICIES_CORRELATION_ID); | |||
| putFile.setSdlFileName("response_data"); | |||
| putFile.setFileData(response.toString().getBytes("UTF-8")); | |||
| updateBroadcastIntent(sendIntent, "DATA", "Data from cloud response: " + response.toString()); | |||
| putFile.setCRC(response.toString().getBytes()); | |||
| updateBroadcastIntent(sendIntent, "DATA", "Data from cloud response: " + response.toString()); | |||
There was a problem hiding this comment.
these dont need to be tabbed
| public static final String KEY_LENGTH = "length"; | ||
|
|
||
| public static final String KEY_LENGTH = "length"; | ||
| public static final String KEY_CRC = "crc"; |
| /** | ||
| * The data sent failed to pass CRC check in receiver end | ||
| */ | ||
| CORRUPTED_DATA; |
| public static final String KEY_LENGTH = "length"; | ||
|
|
||
| public static final String KEY_LENGTH = "length"; | ||
| public static final String KEY_CRC = "crc"; |
|
Do you need to also add the param for the other |
askirk
reviewed
May 11, 2017
| @@ -30,6 +30,7 @@ protected RPCMessage createMessage() { | |||
| msg.setSystemFile(Test.GENERAL_BOOLEAN); | |||
| msg.setOffset(Test.GENERAL_LONG); | |||
| msg.setLength(Test.GENERAL_LONG); | |||
| msg.setCRC(Test.GENERAL_LONG); | |||
There was a problem hiding this comment.
Maybe another test where you use the setCRC(byte[] data) call?
added 2 commits
May 11, 2017 16:47
|
Resolves #452 |
# Conflicts: # sdl_android/src/androidTest/java/com/smartdevicelink/test/rpc/enums/ResultTests.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/PutFile.java # sdl_android/src/main/java/com/smartdevicelink/proxy/rpc/enums/Result.java
Codecov Report
@@ Coverage Diff @@
## develop #510 +/- ##
============================================
+ Coverage 42.38% 42.4% +0.02%
- Complexity 2794 2800 +6
============================================
Files 362 362
Lines 16862 16884 +22
Branches 1724 1727 +3
============================================
+ Hits 7147 7160 +13
- Misses 9403 9411 +8
- Partials 312 313 +1
Continue to review full report at Codecov.
|
|
@askirk @bilal-alsharifi @joeygrover This is ready for re-review |
bilal-alsharifi
approved these changes
May 23, 2018
|
Tested working against Core PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added getting n setters in Putfile, applied setter in RPCRequestFactory and SDLProxyBase, CORRUPT_DATA to Result enum, added tests.