Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add related changes from SDL-0317 proposal #80

Conversation

AKalinich-Luxoft
Copy link
Contributor

Added some documentation to reflect changes from the proposal: SDL Protocol Security Specification

@AKalinich-Luxoft
Copy link
Contributor Author

@theresalech this PR is ready for Livio review

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few suggestions. Also, it might be worth creating a subsection for security-related pages in the guides, which RPC Encryption could go under as well.

docs/Security/Protected Services
docs/Security/RPC Encryption

docs/Protected Services/index.md Outdated Show resolved Hide resolved
docs/Protected Services/index.md Outdated Show resolved Hide resolved
docs/Protected Services/index.md Outdated Show resolved Hide resolved
docs/Protected Services/index.md Outdated Show resolved Hide resolved
docs/Protected Services/index.md Outdated Show resolved Hide resolved
AKalinich-Luxoft and others added 2 commits July 21, 2021 19:04
Co-authored-by: Jacob Keeler <jacob.keeler@livioradio.com>
@AKalinich-Luxoft
Copy link
Contributor Author

Left a few suggestions. Also, it might be worth creating a subsection for security-related pages in the guides, which RPC Encryption could go under as well.

docs/Security/Protected Services
docs/Security/RPC Encryption

@jacobkeeler I moved these two categories to a separate sub-folder in 40447ee

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, you will need to update config.json to make these pages appear in the dev portal.

In place of:

        {
            "name":"RPC Encryption"
        },

you would put:

        {
            "name":"Security",
            "navigation":[
                {
                    "name":"Protected Services"
                },
                {
                    "name":"RPC Encryption"
                }
            ]
        },

docs/Security/Protected Services/index.md Show resolved Hide resolved
@AKalinich-Luxoft
Copy link
Contributor Author

Also, you will need to update config.json to make these pages appear in the dev portal.

In place of:

        {
            "name":"RPC Encryption"
        },

you would put:

        {
            "name":"Security",
            "navigation":[
                {
                    "name":"Protected Services"
                },
                {
                    "name":"RPC Encryption"
                }
            ]
        },

@jacobkeeler thank you for mentioning this file. Updated in 250cf04

@jacobkeeler jacobkeeler merged commit 488d8b8 into smartdevicelink:develop Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants