Feature/promise server logic #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Feedback applied. Additionally, the getAppCertificateByUuid function returned an array of data instead of a single element, which differed from the original version. The database function asyncTransaction now re-throws any caught errors so that the server logic also knows whether the transaction fails. |
renonick87
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
This PR is ready for review.
Risk
This PR makes no API changes.
Summary
This is an overhaul on the logic of the backend of the policy server. Older methods and libraries of handling asynchronous logic have been replaced with Promises and the async/await syntax. This is intended not to affect any functionality with the front-end or with the existing routes, so it should be fully compatible with how it currently functions.