Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartridge removes the .openshift directory on install #10

Closed
OllieRunsBikes opened this issue May 18, 2014 · 3 comments
Closed

Cartridge removes the .openshift directory on install #10

OllieRunsBikes opened this issue May 18, 2014 · 3 comments

Comments

@OllieRunsBikes
Copy link
Contributor

I have been working with the go cartridge and it is excellent, thank you for the work. I think I have found a problem where on the install of an application the .openshift directory gets removed from $OPENSHIFT_REPO_DIR

I have setup a cron directory in .openshift and installed the cron cartridge and created the directories and git pushed to openshift:

screen shot 2014-05-18 at 10 03 18

When I then go into the $OPENSHIFT_REPO_DIR from where the cron files are run there is no .openshift directory:

screen shot 2014-05-18 at 10 09 02

I think line 91 in compile might be the offending line:

rm -rf $build/.openshift # this removes the constructed $GOPATH

But I am unsure of what further effect this might have. I will have a go and fix it but thought some one might have a quick solution to the bug.

@OllieRunsBikes
Copy link
Contributor Author

So I forked and commented out the line 91 in complie:

#rm -rf $build/.openshift # this removes the constructed $GOPATH

This resulted in the .openshift directory being left in place but it also left the ./openshift/g directory which needs to be removed so the fix is for line 9 of compile.

rm -rf $build/.openshift/g # this removes the constructed $GOPATH

screen shot 2014-05-19 at 19 25 05

@OllieRunsBikes
Copy link
Contributor Author

I have created a pull request and am closing this issue as this hopefully fixes the issue.

screen shot 2014-05-19 at 19 37 29

@kshaw
Copy link

kshaw commented Oct 23, 2014

I just ran into this issue with a go app I have running in openshift. Has the pull request not been accepted yet?

smarterclayton added a commit that referenced this issue Oct 29, 2014
Based on issue #10 here is a fix to leave the .openshift directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants