Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the download_to_path keyword argument to the download method. #23

Merged
merged 1 commit into from
Apr 27, 2018

Conversation

chaps
Copy link
Contributor

@chaps chaps commented Apr 18, 2018

Edits smartfile/init.py

  • Adds a download_to_path keyword argument to explicitly specify a
    path to write the downloaded file contents , if not given the file
    will be written under the CWD + the file to download name.

Edits smartfile/__init__.py
 - Adds a download_to_path keyword argument to explicitly specify a
 path to write the downloaded file contents , if not given the file
 will be written under the CWD + the file to download name.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a on chaps:fix_download_file_path into c04d475 on smartfile:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a on chaps:fix_download_file_path into c04d475 on smartfile:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 69.6% when pulling 89a816a on chaps:fix_download_file_path into c04d475 on smartfile:master.

@Ryanb58
Copy link
Contributor

Ryanb58 commented Apr 27, 2018

Good change @chaps Thanks

@Ryanb58 Ryanb58 merged commit f9ccc40 into smartfile:master Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants