Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lib.connection #410

Closed
Morg42 opened this issue Mar 30, 2021 · 7 comments
Closed

Remove lib.connection #410

Morg42 opened this issue Mar 30, 2021 · 7 comments
Assignees
Labels
Milestone

Comments

@Morg42
Copy link
Member

Morg42 commented Mar 30, 2021

After transitioning active code in core and plugins to lib.network, the lib.connection ist obsolete (concerning code checked in on GitHub / smarthomeNG) following issue 399 @plugins

One consideration before finally removing lib.connection should be a way to warn users incorporation lib.connection in private plugins.

Options might be

  • displaying a warning in AdminUI
  • writing a warning to the log
  • writing a warning to the console
  • ...?

Removal should be planned earliest for 1.10, latest for 2.0, IMHO.

@Morg42
Copy link
Member Author

Morg42 commented Feb 23, 2023

Todo: check plugins before next release

@Morg42 Morg42 self-assigned this Feb 23, 2023
@Morg42
Copy link
Member Author

Morg42 commented Mar 9, 2023

currently using lib.connections:

  • LOGO @bmxp
  • comfoair (inactive?)

@bmxp
Copy link
Member

bmxp commented Mar 9, 2023

LOGO might be still in use by @ivande, I have no idea about comfoair

@msinn
Copy link
Member

msinn commented Mar 9, 2023

Maybe you should ask in the forum and on gitter, if the two plugins are still in use (and if someone is maintaining them).

@Morg42
Copy link
Member Author

Morg42 commented Mar 10, 2023

Checking again, I already migrated the monitor functionality to lib.network, so only plugins explicitly importing lib.connection might need to be adjusted.

sv_websocket is one building its own network server from lib.connections, but as far as I recall this is deprecated...

So lib.connection could be removed at one of the next releases. The deprecation warning is already implemented for those using lib.connection in private plugins.

@msinn
Copy link
Member

msinn commented Mar 13, 2023

Sc_websocket ist deprecated and will be retired in v1.10. There is no need to update it. It has been replaced by the websocket module.

@msinn
Copy link
Member

msinn commented Mar 14, 2023

SmartHomeNG v1.9.4 has been released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants