[transform.basicprofiles] Added Debounce Profile - Counting Strategy #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
commented
May 25, 2021
J-N-K
requested changes
May 26, 2021
|
|
||
| <config-description uri="profile:basic-profiles:debounce-counting"> | ||
| <parameter name="numberOfChanges" type="integer" min="0" step="1"> | ||
| <label>Number of Changes</label> |
There was a problem hiding this comment.
Suggested change
| <label>Number of Changes</label> | |
| <label>Number Of Changes</label> |
| @@ -8,6 +8,10 @@ profile-type.basic-profiles.toggle-switch.label = Generic Toggle Switch | |||
| profile.config.basic-profiles.toggle-switch.events.label = Ereignisse | |||
| profile.config.basic-profiles.toggle-switch.events.description = Kommagetrennte Liste der Ereignisse, die das Profil verfolgen soll. | |||
|
|
|||
| profile-type.basic-profiles.debounce-counting.label = Debounce (Z�hler) | |||
There was a problem hiding this comment.
Suggested change
| profile-type.basic-profiles.debounce-counting.label = Debounce (Z�hler) | |
| profile-type.basic-profiles.debounce-counting.label = Entprellen (Z�hler) |
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cweitkamp
force-pushed
the
feature-debounce-profile
branch
from
1e6de37
to
e504715
Compare
J-N-K
changed the title
J-N-K
approved these changes
May 27, 2021
J-N-K
pushed a commit
that referenced
this pull request
May 27, 2021
…113) * Added Debounce Profile - Counting Strategy Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic approach to debounce a state update via counting strategy. As mentioned in the related OHC issue there are other strategies to archive similar results too (e.g. time-based debouncing).
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de