[amazonechocontrol] add do not disturb channel #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-N-K
requested changes
Jul 21, 2022
...rol/src/main/java/org/smarthomej/binding/amazonechocontrol/internal/handler/EchoHandler.java
Outdated
Show resolved
Hide resolved
J-N-K
reviewed
Jul 21, 2022
...rol/src/main/java/org/smarthomej/binding/amazonechocontrol/internal/handler/EchoHandler.java
Outdated
Show resolved
Hide resolved
ccutrer
force-pushed
the
amazonechocontrol-dnd
branch
from
e9b23ad
to
f5d039b
Compare
|
all suggestions applied |
J-N-K
requested changes
Jul 21, 2022
There was a problem hiding this comment.
I forgot something. We need to add the thing to each of the thing-update-lists:
2;ADD_CHANNEL;doNotDisturb,Switch,amazonechocontrol:doNotDisturb
By doing so all UI configured things will be updated with the new channel (so you don't habe to delete and re-add the thing).
| @@ -206,6 +208,7 @@ | |||
| <channel id="lastSpokenText" typeId="lastSpokenText"/> | |||
| <channel id="notificationVolume" typeId="notificationVolume"/> | |||
| <channel id="ascendingAlarm" typeId="ascendingAlarm"/> | |||
| <channel id="doNotDisturb" typeId="doNotDisturb"/> | |||
| </channels> | |||
| <properties> | |||
| <property name="thingTypeVersion">1</property> | |||
There was a problem hiding this comment.
Suggested change
| <property name="thingTypeVersion">1</property> | |
| <property name="thingTypeVersion">2</property> |
| @@ -147,6 +148,7 @@ | |||
| <channel id="lastSpokenText" typeId="lastSpokenText"/> | |||
| <channel id="notificationVolume" typeId="notificationVolume"/> | |||
| <channel id="ascendingAlarm" typeId="ascendingAlarm"/> | |||
| <channel id="doNotDisturb" typeId="doNotDisturb"/> | |||
| </channels> | |||
| <properties> | |||
| <property name="thingTypeVersion">1</property> | |||
There was a problem hiding this comment.
Suggested change
| <property name="thingTypeVersion">1</property> | |
| <property name="thingTypeVersion">2</property> |
| @@ -88,6 +88,7 @@ | |||
| <channel id="lastSpokenText" typeId="lastSpokenText"/> | |||
| <channel id="notificationVolume" typeId="notificationVolume"/> | |||
| <channel id="ascendingAlarm" typeId="ascendingAlarm"/> | |||
| <channel id="doNotDisturb" typeId="doNotDisturb"/> | |||
| </channels> | |||
| <properties> | |||
| <property name="thingTypeVersion">1</property> | |||
There was a problem hiding this comment.
Suggested change
| <property name="thingTypeVersion">1</property> | |
| <property name="thingTypeVersion">2</property> |
Signed-off-by: Cody Cutrer <cody@cutrer.us>
ccutrer
force-pushed
the
amazonechocontrol-dnd
branch
from
f5d039b
to
b96e261
Compare
|
oh cool, I didn't know about that. that's much better. I have 20 echos, so it's really nice to not have to recreate them all! |
J-N-K
approved these changes
Jul 21, 2022
|
Thank you very much! |
rogrun
pushed a commit
to rogrun/addons
that referenced
this pull request
Aug 22, 2022
…homej#391) Signed-off-by: Cody Cutrer <cody@cutrer.us> Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cody Cutrer cody@cutrer.us