[viessmann] add status channel for OneTimeCharge #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
|
Ready for Review. |
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
J-N-K
requested changes
Nov 12, 2022
...mann/src/main/java/org/smarthomej/binding/viessmann/internal/config/BridgeConfiguration.java
Outdated
Show resolved
Hide resolved
...viessmann/src/main/java/org/smarthomej/binding/viessmann/internal/handler/DeviceHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/smarthomej/binding/viessmann/internal/handler/ViessmannBridgeHandler.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/smarthomej/binding/viessmann/internal/handler/ViessmannBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
J-N-K
previously approved these changes
Nov 13, 2022
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
J-N-K
approved these changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Adds a channel which provides the state of OneTimeCharge. (Device Thing)
Adds the ability to disable polling. (Bridge Thing)
Adds channels for manual polling. (Bridge Thing)
Improves the channel type for channels w/o commands to read-only.
Also fixes some typo.
Signed-off-by: Ronny Grun ronny.grun@t-online.de