Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[viessmann] Add the unit cubic meters for consumption #431

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

rogrun
Copy link
Contributor

@rogrun rogrun commented Dec 16, 2022

  • Add the unit cubic meters for consumption

Signed-off-by: Ronny Grun ronny.grun@t-online.de

Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@J-N-K J-N-K requested a review from cweitkamp December 17, 2022 20:37
cweitkamp
cweitkamp previously approved these changes Dec 18, 2022
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor remark on syntax. Feel free to fix it or not.

Signed-off-by: Ronny Grun <ronny.grun@t-online.de>
@rogrun
Copy link
Contributor Author

rogrun commented Dec 19, 2022

@J-N-K ready for review

@J-N-K J-N-K merged commit 4d7c167 into smarthomej:3.2.x Dec 20, 2022
@rogrun rogrun deleted the viessmann-add-uom-cubicmeter branch January 3, 2023 07:45
@J-N-K J-N-K added this to the 3.2.16 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants