[chain] Initial contribution #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cweitkamp: WDYT? |
|
This looks cool. 😎 Very useful. |
J-N-K
changed the title
cweitkamp
reviewed
May 16, 2021
|
|
||
| ## Example: Door lock | ||
|
|
||
| A lock that can report its status and accepts commands as JSON and accepts commands. |
There was a problem hiding this comment.
Suggested change
| A lock that can report its status and accepts commands as JSON and accepts commands. | |
| A lock that can report its status and accepts commands in JSON. |
| @Override | ||
| public @Nullable Profile createProfile(ProfileTypeUID profileTypeUID, ProfileCallback callback, | ||
| ProfileContext profileContext) { | ||
| return new ChainTransformationProfile(callback, profileContext, valueTransformationProvider); |
There was a problem hiding this comment.
IIRC you should check for matching ProfileTypeUID or return null otherwise. I am not sure if the calling instance checks the factory for getSupportedProfileTypeUIDs() or not.
Suggested change
| return new ChainTransformationProfile(callback, profileContext, valueTransformationProvider); | |
| return ChainTransformationProfile.PROFILE_TYPE_UID.equals(profileTypeUID) ? new ChainTransformationProfile(callback, profileContext, valueTransformationProvider) : null; |
| * @author Jan N. Klug - Initial contribution | ||
| */ | ||
| @NonNullByDefault | ||
| public class TestProfileContext implements ProfileContext { |
There was a problem hiding this comment.
Do you really need this helper class? Or can you mock it?
cweitkamp
reviewed
May 16, 2021
cweitkamp
previously approved these changes
May 16, 2021
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
J-N-K
added a commit
that referenced
this pull request
May 16, 2021
* Initial contribution Signed-off-by: Jan N. Klug <jan.n.klug@rub.de>
J-N-K
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a profile that allows chaining transformations.
Signed-off-by: Jan N. Klug jan.n.klug@rub.de