Check for sane options in email_notifier #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because #set_data_variables will create instance variables for each key found in options[:data], check to make sure key names are sane and will not interfer with functioning of EmailNotifier.
|
I have the same problem, however I'm passing the params I get from an HTTP request which I don't control, so this solution doesn't help. I don't understand why instance variables are necessary, wouldn't it be safer/simpler, if there was only one instance variable containing the passed data option? |
|
I have the same problem. Would it be better to prefix all internal variables with underscore (for instance, |
smartinez87
force-pushed
the
master
branch
2 times, most recently
from
b2b9f49
to
c1976c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because #set_data_variables will create instance variables for
each key found in options[:data], check to make sure key names are
sane and will not interfer with functioning of EmailNotifier.