Fix rubocop offenses #444
Merged
Fix rubocop offenses #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 similar comments
EmilioCristalli
approved these changes
Dec 29, 2018
| s.add_development_dependency 'hipchat', '>= 1.0.0' | ||
| s.add_development_dependency 'httparty', '~> 0.10.2' | ||
| s.add_development_dependency 'mocha', '>= 0.13.0' | ||
| s.add_development_dependency 'sidekiq', '~> 3.0.0', '< 3.2.2' |
There was a problem hiding this comment.
wdyt about moving the sidekick comment above this line?
exception_notification.gemspec
Outdated
|
|
||
| s.add_development_dependency "rails", ">= 4.0", "< 6" | ||
| s.add_development_dependency "resque", "~> 1.2.0" | ||
| s.add_development_dependency 'rails', '>= 4.0', '< 6' |
There was a problem hiding this comment.
should these two dev dependencies be ordered alphabetically as well?
| @@ -0,0 +1 @@ | |||
| inherit_from: .rubocop_todo.yml | |||
There was a problem hiding this comment.
wdyt about adding the TargetRubyVersion here? and maybe DisplayCopNames as well?
AllCops:
TargetRubyVersion: 2.0
DisplayCopNames: true
will probably need to add rubocop as a dev dependency too, i think version 0.50.0 is the last one to support ruby 2.0
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.