Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rails 6 #452

Merged
merged 7 commits into from Aug 16, 2019
Merged

Support Rails 6 #452

merged 7 commits into from Aug 16, 2019

Conversation

shanecav84
Copy link

@shanecav84 shanecav84 commented Jan 19, 2019

Wanted to test my own apps and needed to do this locally anyway. Might as well get this PR started.

@coveralls
Copy link

coveralls commented Jan 19, 2019

Coverage Status

Coverage decreased (-0.2%) to 96.679% when pulling 9f70bd4 on shanecav84:rails_6 into ecc06f6 on smartinez87:master.

@shanecav84 shanecav84 force-pushed the rails_6 branch 4 times, most recently from 7e0d345 to a707ac7 Compare January 19, 2019 21:43
@shanecav84
Copy link
Author

shanecav84 commented Jan 19, 2019

Changes so far:

  • Support Rails 6.0.0.beta
  • Removed coveralls until thor is updated because Rails 6 requires a higher version than coveralls allows
  • Avoid the following deprecation warning for Rails version >= 6:
    DEPRECATION WARNING: `Module#parent_name` has been renamed to `module_parent_name`.
    `parent_name` is deprecated and will be removed in Rails 6.1.
    

@shanecav84 shanecav84 force-pushed the rails_6 branch 2 times, most recently from 71c666f to ddda9c5 Compare January 25, 2019 17:02
@FLarra FLarra added the WIP Work in progress label Jan 29, 2019
@ansonhoyt
Copy link

Are you good folks still working on this? Looks like you made good progress, and now that Rails 6.0.0.rc1 is out, you should have a solid target to land this against.

@shanecav84
Copy link
Author

I've updated rails to 6.0.0.rc1 and rebased on master.

@EmilioCristalli
Copy link
Collaborator

thanks for the update @shanecav84 ! is this still a WIP or you think it's ready?

@shanecav84
Copy link
Author

I don’t think anything will need to change between now and an official Rails 6 release other than rebasing.

@axlekb
Copy link

axlekb commented Aug 16, 2019

Ready for update! :-)

@smartinez87 smartinez87 merged commit 47c56a3 into smartinez87:master Aug 16, 2019
@shanecav84
Copy link
Author

Finally 😄

@shanecav84
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants