Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable prettier formatting on CI #383

Merged
merged 5 commits into from
Oct 7, 2022
Merged

Enable prettier formatting on CI #383

merged 5 commits into from
Oct 7, 2022

Conversation

stellarhoof
Copy link
Member

@stellarhoof stellarhoof commented Oct 7, 2022 •
edited
Loading

☝️

@stellarhoof stellarhoof self-assigned this Oct 7, 2022
@stellarhoof stellarhoof force-pushed the feature/enable-prettier-formatting branch from b9e5326 to c0c77e5 Compare October 7, 2022 17:48
@stellarhoof stellarhoof force-pushed the feature/enable-prettier-formatting branch from c0c77e5 to 0cb57dc Compare October 7, 2022 17:52
@decrapifier
Copy link
Contributor

decrapifier commented Oct 7, 2022 •
edited
Loading

Fails
🚫 The version was not updated. Please update the version.
🚫 Browser test error. Please see CI logs for more details.
Warnings
⚠️ ❗ This PR is BIG (+1854 -1486) Please keep it below 500 net changes

Generated by 🚫 dangerJS against 31f1a66

positiveVibes4all
positiveVibes4all approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@positiveVibes4all positiveVibes4all left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@stellarhoof stellarhoof merged commit 46afd39 into master Oct 7, 2022
@stellarhoof stellarhoof deleted the feature/enable-prettier-formatting branch October 7, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@positiveVibes4all positiveVibes4all positiveVibes4all approved these changes

@daedalus28 daedalus28 Awaiting requested review from daedalus28

Assignees

@stellarhoof stellarhoof

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stellarhoof @decrapifier @positiveVibes4all