Adopt FIWARE contribution guidelines #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c0c0n3
commented
Nov 6, 2020
c0c0n3
commented
Nov 6, 2020
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # the below token should have repo scope and must be manually added by you in the repository's secret | ||
| PERSONAL_ACCESS_TOKEN : ${{ secrets.PERSONAL_ACCESS_TOKEN }} |
There was a problem hiding this comment.
Added PERSONAL_ACCESS_TOKEN secret to QL repo but the value is bogus, still need to figure out how to generate a valid token which only gives access to the QL repos, not all repos linked to an account.
chicco785
reviewed
Nov 9, 2020
chicco785
force-pushed
the
feature/cla
branch
from
c495441
to
dc27339
Compare
chicco785
approved these changes
Nov 19, 2020
chicco785
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes QL comply with FiWare tech committee's recent decision about contribution guidelines and CLA---see #389. Specifically we have
Notice the signing of CLA uses a GitHub action that probably won't work out of the box for us since our
masterbranch is protected. Let's see what happens after the merge, if it actually works then all the better, otherwise we'll have to come up with a workaround.Also I've added a repo secret called
PERSONAL_ACCESS_TOKEN---which is what the GitHub action looks forThe secret's value is just a placeholder for now. We'll have to generate a personal access token with a scope of
repo:and then set
PERSONAL_ACCESS_TOKENto that token. I've tried generating one using my personal GitHub account but I couldn't manage to make it specific to this repo, i.e. I can only generate a token that gives access to all of my repos, including my private ones!