Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor releasing IP #3

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

haijianyang
Copy link
Contributor

优化 IP 释放

之前释放 IP 和 删除 ElfMachine 是并行的,可能导致提前释放虚拟机还在使用的 IP 分配给其他的集群使用。
在删除 ElfMachine 之后再释放 IP 资源。

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #3 (d6715cb) into main (886b294) will increase coverage by 0.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   72.59%   73.11%   +0.51%     
==========================================
  Files           1        1              
  Lines         208      212       +4     
==========================================
+ Hits          151      155       +4     
  Misses         39       39              
  Partials       18       18              
Impacted Files Coverage Δ
controllers/elfmachine_controller.go 73.11% <100.00%> (+0.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

controllers/elfmachine_controller.go Outdated Show resolved Hide resolved
controllers/elfmachine_controller.go Outdated Show resolved Hide resolved
@haijianyang haijianyang merged commit aac8ba6 into smartxworks:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants