Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project for PHP8.1 #704

Closed
wants to merge 1 commit into from
Closed

Update project for PHP8.1 #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/sysplugins/smartycompilerexception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ public function __toString()
/**
* The line number of the template error
*
* @type int|null
* @type int
*/
public $line = null;
public $line;
Copy link
Contributor

@thirsch thirsch Jan 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this does not solve the issue for us. We are still getting the following error:

NOTICE: PHP message: PHP Fatal error: Type of SmartyCompilerException::$line must be int (as in class Exception) in .../vendor/smarty/smarty/libs/sysplugins/smartycompilerexception.php on line 8

If I change the line to public int $line;, everything is working, but this is not backward compatible to php < 7.4


/**
* The template source snippet relating to the error
Expand Down