Update project for PHP8.1 #704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PHP8.1 is asking strict type, removed `$line = null` default value in smartycompilerexception.php
thirsch
reviewed
Jan 17, 2022
| */ | ||
| public $line = null; | ||
| public $line; |
There was a problem hiding this comment.
Unfortunately, this does not solve the issue for us. We are still getting the following error:
NOTICE: PHP message: PHP Fatal error: Type of SmartyCompilerException::$line must be int (as in class Exception) in .../vendor/smarty/smarty/libs/sysplugins/smartycompilerexception.php on line 8
If I change the line to public int $line;, everything is working, but this is not backward compatible to php < 7.4
|
Please see #713 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP8.1 is asking strict type, removed
$line = nulldefault value in smartycompilerexception.php