PHP 8.1 compatibility (without IntlDateFormatter)

[thirsch]

This is the follow-up for #711. I tried to keep as many commits without modification here. Hope that's ok @got

I coudn't find a way to update the previous pr, sorry.

[glensc]

since you closed previous one, carry the discussion:

• php 8.1 compatibility #711 (comment)

[thirsch]

Shall we continue the discussion here? My last answer was:

Personally I agree with your point, but IMO it's out of scope of this change. What the original author tried to do is "doing whatever php < 8.1 would do". So another pr should cope with the issue.

But we can also remove the change in line #199 as it's only a deprecation warning in php 8.1

[glensc]

I have no say of this, as I'm not the maintainer.

personally, I would carry the fix to separate PR and hope it gets merged sooner as the change is smaller.

ps: edit #199 to be backticks as it links to bogus ticket, or replace with link to source

[trasher]

Hi,
There are still strftime calls that will make Smarty fail with PHP 8.1:

libs/plugins/function.html_select_date.php:                ($month_format === '%m' ? $_val : strftime($month_format, $_month_timestamps[ $i ]));
libs/plugins/function.html_select_date.php:            $_value = $month_value_format === '%m' ? $_val : strftime($month_value_format, $_month_timestamps[ $i ]);
libs/plugins/modifier.date_format.php:        return strftime($format, $timestamp);

Can a maintainer approve the actions workflow run so we can also see tests results? Thanks!

[thirsch]

Hi, There are still strftime calls that will make Smarty fail with PHP 8.1 [...]

yes, please see the discussion in #678. This pr is just a follow-up without fixing the strftime issues. These are deprecations only and the main goal is to get smarty running under 8.1.

[trasher]

Yes, I've realized. Thanks.

[iwiznia]

Nice, thanks @thirsch!!
@wisskid is there going to be a new version release to include these changes?

[thirsch]

Kudos clearly must go to @atomiix!

[acun87]

id_ed25519.pub