Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release, 4.7.0, is broken #23

Closed
tsibley opened this issue Oct 30, 2020 · 3 comments
Closed

Latest release, 4.7.0, is broken #23

tsibley opened this issue Oct 30, 2020 · 3 comments

Comments

@tsibley
Copy link

tsibley commented Oct 30, 2020

The latest release, version 4.7.0, appears to be broken because of a packaging/distribution error. The new smartystreets_python_sdk.us_reverse_geo package is missing from setup.py:

packages=[
'smartystreets_python_sdk',
'smartystreets_python_sdk_version',
'smartystreets_python_sdk.us_street',
'smartystreets_python_sdk.us_zipcode',
'smartystreets_python_sdk.us_extract',
'smartystreets_python_sdk.us_autocomplete',
'smartystreets_python_sdk.international_street',
],

and thus doesn't get installed. ModuleNotFoundErrors occur when trying to use the ClientBuilder, which imports us_reverse_geo:

Traceback (most recent call last):
  …
  File "…", line 32, in <module>
    from smartystreets_python_sdk import StaticCredentials, ClientBuilder
  File "…/lib/python3.6/site-packages/smartystreets_python_sdk/__init__.py", line 13, in <module>
    from .client_builder import ClientBuilder
  File "…/lib/python3.6/site-packages/smartystreets_python_sdk/client_builder.py", line 6, in <module>
    from smartystreets_python_sdk.us_reverse_geo import Client as USReverseGeoClient
ModuleNotFoundError: No module named 'smartystreets_python_sdk.us_reverse_geo'
@tsibley
Copy link
Author

tsibley commented Oct 30, 2020

Reproduction:

$ python3 -m venv /tmp/venv
$ /tmp/venv/bin/pip install smartystreets-python-sdk==4.7.0
$ /tmp/venv/bin/python3 -c 'from smartystreets_python_sdk import ClientBuilder'

@DuncanBeutler
Copy link
Contributor

Thanks for raising this issue. Changes have been made to the setup file on version 4.7.1, let us know if there are persisting issues

tsibley added a commit to seattleflu/id3c that referenced this issue Nov 5, 2020
Allows future releases while still excluding the known-bad release,
4.7.0.

SmartyStreets released 4.7.1 to fix the issue:

  smartystreets/smartystreets-python-sdk#23
@tsibley
Copy link
Author

tsibley commented Nov 5, 2020

This appears resolved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants