Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release, 4.8.0, is broken #30

Closed
tsibley opened this issue Mar 23, 2021 · 1 comment
Closed

Latest release, 4.8.0, is broken #30

tsibley opened this issue Mar 23, 2021 · 1 comment

Comments

@tsibley
Copy link

tsibley commented Mar 23, 2021

The latest release, version 4.8.0, appears to be broken because of a packaging/distribution error. The new smartystreets_python_sdk.us_autocomplete_pro package is missing from setup.py:

packages=[
'smartystreets_python_sdk',
'smartystreets_python_sdk_version',
'smartystreets_python_sdk.us_street',
'smartystreets_python_sdk.us_zipcode',
'smartystreets_python_sdk.us_extract',
'smartystreets_python_sdk.us_autocomplete',
'smartystreets_python_sdk.international_street',
'smartystreets_python_sdk.us_reverse_geo',
],

and thus doesn't get installed. ModuleNotFoundErrors occur when trying to use the ClientBuilder, which imports us_autocomplete_pro:

Traceback (most recent call last):
  …
  File "…", line 32, in <module>
    from smartystreets_python_sdk import StaticCredentials, ClientBuilder
  File "…/lib/python3.6/site-packages/smartystreets_python_sdk/__init__.py", line 13, in <module>
    from .client_builder import ClientBuilder
  File "…/lib/python3.6/site-packages/smartystreets_python_sdk/client_builder.py", line 6, in <module>
    from smartystreets_python_sdk.us_autocomplete_pro import Client as USAutocompleteProClient
ModuleNotFoundError: No module named 'smartystreets_python_sdk.us_autocomplete_pro'

A similar issue with a different new module occurred with the 4.7.0 release last year.

@mdwhatcott
Copy link
Contributor

Fixed by PR #31

tsibley added a commit to seattleflu/id3c that referenced this issue Apr 6, 2021
Allows future releases while still excluding the known-bad release,
4.8.0.

SmartyStreets released 4.8.1 to fix the issue:

  smartystreets/smartystreets-python-sdk#30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants