Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New opengl rendering breaks some stuff #30

Closed
smcameron opened this issue Dec 20, 2013 · 4 comments
Closed

New opengl rendering breaks some stuff #30

smcameron opened this issue Dec 20, 2013 · 4 comments

Comments

@smcameron
Copy link
Owner

Just recording this here so these things don't fall off the map and to make it clear that these are known issues.

Some rendering modes don't work anymore after commit bbd7409

  • flat shading with wireframe outline
  • wireframe with black_tris
  • bright line wireframe
  • dotted lines in a liine mesh
  • nav trident isn't colored by depth
  • Derelict objects show up as gray silhouettes (probably due
    to incorrect normals, mesh_derelict() needs attention, and new
    code for computing vertex normals and coplanar triangles for meshes
    outside the context of reading meshes from stl files needs to be
    written.
  • Skybox is broken
@smcameron
Copy link
Owner Author

Derelicts and asteroid shading is now partially fixed by giving them all vertex normals that are just copied from the triangle face normals, but it's still not doing the co-planar face stuff, nor the adaptive vertex normal stuff.

@jv4779
Copy link
Contributor

jv4779 commented Dec 24, 2013

Wireframe with black tris and skybox are now working.

I think flat shading with wireframe and brightline wireframe will end up as "will not fix".

@smcameron
Copy link
Owner Author

Fine by me. I only originally had that mode because it was trivially easy in the software renderer to combine wireframe and flat shading, not because it was something that was needed for anything.

@smcameron
Copy link
Owner Author

I think we got most of this either sorted out, or replaced by something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants