Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug helpers #99

Merged
merged 1 commit into from
Jul 20, 2015
Merged

Add debug helpers #99

merged 1 commit into from
Jul 20, 2015

Conversation

smfoote
Copy link
Owner

@smfoote smfoote commented Jun 30, 2015

@contextDump and @debugger

@contextDump and @debugger
@smfoote
Copy link
Owner Author

smfoote commented Jun 30, 2015

Fixes #90

return frag;
}
},
"debugger": function _debugger() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the linter yell at this?

Also, does this preserve the call stack?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the linter doesn't care. The call stack is preserved, but you are a few functions deeper than you would like to be. Once we have compiler helpers, I would like to change this to just put a debugger statement directly in the compiled template. For now this works, though.

@jimmyhchan
Copy link
Collaborator

👍 looks good

prashn64 added a commit that referenced this pull request Jul 20, 2015
@prashn64 prashn64 merged commit 9e78876 into master Jul 20, 2015
@smfoote smfoote deleted the debugging-helpers branch July 20, 2015 19:28
@smfoote smfoote mentioned this pull request Jul 21, 2015
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants