Implement Polaris inline-error component #174
Conversation
vladucu
force-pushed
the
feature/polaris-inline-error
branch
from
12d43b9
to
da1b4bb
Compare
vladucu
changed the title
vladucu
changed the title
|
|
||
| init() { | ||
| this._super(...arguments); | ||
| assert('[polaris-inline-error] Missing required `fieldID` param!', this.get('fieldID')); |
There was a problem hiding this comment.
can we start using this.fieldID instead of this.get?
There was a problem hiding this comment.
was bitten by this the other day...it won't work in apps on pre-ember 3.1
is there any way to support older versions of Ember too in the addon?
| <div | ||
| class="Polaris-InlineError" | ||
| id={{concat fieldID "Error"}} | ||
| data-test-inline-error={{data-test-inline-error}} |
There was a problem hiding this comment.
If we had it as,
then we wouldn't need to set the same on the class as boolean flags. You could find the usage here.
There was a problem hiding this comment.
yes, but in a consuming app, in an acceptance test where you have multiple instances....would complicate testing no?
There was a problem hiding this comment.
so you could do for example:
and just directly use these selectors in tests....
There was a problem hiding this comment.
ah got it 🙂👍🏻. May be we could add a note in our readme doc somewhere under the testing section about this
|
|
||
| init() { | ||
| this._super(...arguments); | ||
| assert('[polaris-inline-error] Missing required `fieldID` param!', this.get('fieldID')); |
There was a problem hiding this comment.
The React component doesn't seem to care about this... why do we?
There was a problem hiding this comment.
the docs mention it's required...I'm fine with dropping this, tbh
There was a problem hiding this comment.
True... don't see anything in the code enforcing it but maybe there's something in React that requires the props to be present 🤷♂️
| }} | ||
| `); | ||
|
|
||
| assert.dom('[data-test-inline-error]').exists(); |
There was a problem hiding this comment.
These test selectors are pretty neat 😄
fix #175