Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript #58

Merged
merged 42 commits into from
Jan 5, 2023
Merged

Add typescript #58

merged 42 commits into from
Jan 5, 2023

Conversation

ayinloya
Copy link
Collaborator

@ayinloya ayinloya commented Dec 19, 2022

Add types to sdk
Generate js from typescript

Resolves #23

@ayinloya ayinloya mentioned this pull request Dec 21, 2022
Fix lint issue
Update eslint config
Build js files in ci before test and deployment
Install example dependency before lint
Remove example package install from ci
@ayinloya ayinloya self-assigned this Dec 21, 2022
index.ts Outdated Show resolved Hide resolved
src/constants.ts Outdated Show resolved Hide resolved
src/shared.ts Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
examples/server.js Outdated Show resolved Hide resolved
examples/package.json Show resolved Hide resolved
.github/workflows/npm-publish.yml Outdated Show resolved Hide resolved
@ayinloya ayinloya requested a review from cmrfrd January 4, 2023 17:02
Copy link
Contributor

@mldangelo mldangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Please feel free to merge when you are ready. Just consider updating the README to mention typescript and please don't forget to talk about your changes in the changelog.

@ayinloya ayinloya merged commit ad6ef3d into main Jan 5, 2023
@ayinloya ayinloya deleted the add-typescript branch January 5, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript declarations?
3 participants