Support for Zeromq3.2

[ralphbean]

Hi, zeromq3.2 isn't quite out yet, but it will be soon! pyzmq has had experimental support for it since pyzmq-2.1.7.

The following commits introduce the start of experimental support for zeromq-3.2. Whether pyzmq is built against zeromq-2.2 or zeromq-3.2, the txZMQ tests should pass.

pubsub works, but the req/rep and router/dealer patterns are broken for reasons I haven't figured out yet.

[ralphbean]

@smira, just chiming in to see if you could comment on this? I've applied this patch to python-txzmq as its packaged in Fedora 18 and I'm using it successfully in our server infrastructure with zeromq3.

It would smooth over problems with some tutorials I'm trying to write if it could be upstreamed and made available on pypi.

If you think it has any problems, I'd be more than happy to try and solve them.

[smira]

Hi @ralphbean, sorry for being so slow with that.

I don't have zeromq3 to test all your patches and don't quite like commits that remove or disable the tests... I would rather merge your support for zeromq3 commit and try to make it working.

[smira]

It looks like zeromq 3.2 isn't drop-in replacement for 2.2... Simply adjusting constants doesn't work. I'll try to do the port, but it may take some time.

[ralphbean]

Cool. I understand about not wanting to disable tests.

If its any consolation, in bcdb56e I tried to only disable the tests when zeromq3 was installed.. so the tests should all still pass for zeromq2 users (i.e., everyone).

We could slowly bring the zeromq3 port around to full conformance with the zeromq2 test suite over time.

But, like I said, I understand not wanting to disable or change any tests in general.

[smira]

@ralphbean, I've pushed your compatibility patch (I've omitted DONTWAIT patch, it doesn't seem to be required). I've fixed tests for pubsub (added comment on 3.x/2.x differences). Also, I've rewritten the doRead in connection class to be compatible with 3.x. Could you please give it a try?

I'm working on req/rep tests, need to figure out why these don't work under 3.x.

[smira]

I've published release 0.5.3 to pypi, it is "hidden" by default: http://pypi.python.org/pypi/txZMQ/0.5.3

[smira]

Ok, I've fixed all the issues with ØMQ 3.2.x. I believe I've fixed bugs in txZMQ itself.

Version 0.6.0 published to PyPi.

Closing this pull request. Thanks, @ralphbean!

[ralphbean]

Awesome, @smira. Thanks!

95c0482 and b02665b both look really good.

I expect it will work fine, but I'll be testing out 0.6 in the coming days -- I'll let you know if I find any problems.

[ralphbean]

Just reporting +1 -- it works just fine in our staging environment.