Updating mzLib, net5.0, and x64 builds #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the AppVeyor and dockerfiles would need to be updated, too. Here are the docker base images I suggested for MM: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the maintenance stuff of updating mzLib, updating to net5.0, and explicitly building with x64 that's used for mzLib.
I couldn't figure out how to get
UtilsandCMDto build without the WindowsDesktop framework, so they still targetnet5.0-windows. I think they should eventually targetnet5.0instead, so that they're cross-platform. I made an issue for that here. #99