MBR update +bugfixes #475
Merged
MBR update +bugfixes #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into mbrUpdate
…uireMonoisotopicMass is turned off
|
Uff da |
zrolfs
reviewed
Jun 22, 2019
FlashLFQ/FlashLfqEngine.cs
Outdated
| @@ -331,7 +326,7 @@ private void QuantifyMs2IdentifiedPeptides(SpectraFileInfo fileInfo) | |||
| xic.RemoveAll(p => !ppmTolerance.Within(p.Mz.ToMass(chargeState), identification.massToLookFor)); | |||
|
|
|||
| // filter by isotopic distribution | |||
| List<IsotopicEnvelope> isotopicEnvelopes = GetIsotopicEnvelopes(xic, identification, chargeState, true); | |||
| List<IsotopicEnvelope> isotopicEnvelopes = GetIsotopicEnvelopes(xic, identification, chargeState, false); | |||
There was a problem hiding this comment.
I thought that not requiring the monoisotopic mass made the data worse?
| @@ -188,7 +187,7 @@ private void NormalizeFractions() | |||
| } | |||
|
|
|||
| // we're only normalizing on a subset of data here because it might take too long to do the whole set | |||
| seenInBothBioreps = SubsetData(seenInBothBioreps, filesForThisBiorep.Concat(filesForCond1Biorep1).ToList()); | |||
| //seenInBothBioreps = SubsetData(seenInBothBioreps, filesForThisBiorep.Concat(filesForCond1Biorep1).ToList()); | |||
|
|
||
| return subsetList.ToList(); | ||
| } | ||
| //private List<Peptide> SubsetData(List<Peptide> initialList, List<SpectraFileInfo> spectraFiles) |
zrolfs
reviewed
Jun 27, 2019
rmillikin
changed the title
leahvschaffer
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.