Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a bug affecting certain reads on macOS Ventura, intel and gcc-13 with O3 optimization.
I added directives for compiler to do less aggressive vector optimization around the tight loops that iterate in parallel while doing alignment in a band. Specifically, the
from_diag
,from_above
andfrom_left
, both those with and without traceback. I was able to alter only a subset of those 6 functions and make certain test cases work, but the only way the entire regression test file indnmtools
would pass is with all 6 functions allowing at not more than thevery-cheap
option for dynamic vectorization. It seems like a second directive can turn the optimization back on for functions below in the file.