-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added module DisplacementBehaviour.jl #45
Conversation
\medskip | ||
|
||
% Description | ||
\indentpar In order to verify the validity of the \emph{VDisp} software, we came |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"In order to" should be replaced by "to". I mention this so that you can get out of the habit of using it. 😄 Other low information content phrases can be found in the link given in my writing checklist.
on p.171, there are 4 sample input files along with their respective expected outputs. | ||
We copied these input files, storing them in the directory located at | ||
\href{https://github.com/smiths/vdisp/tree/main/test/.testdata}{\emph{“vdisp/test/.testdata”}}. | ||
We made our \emph{InputParser} module parse each of these files, making sure no errors arose and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure of the value of using hidden folders to store your test cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try to keep the pull requests focused on one thing. For instance, in the future, the changes to the VnV plan would be better as a separate PR.
What are the instructions for running test cases in julia? I would rather test PRs using the created test cases than the current approach of making temporary changes to vdisp.jl
.
The current PR looks good, so I'll accept it. I won't delete the branch though, in case you want to use it to fix the "in order to" issue.
In order to run the test cases:
|
The instructions are great. Works fine. I suggest that we create a make file with those instructions and a rule |
Added DisplacementBehaviour module. As always, to test add the following lines to the body of the
vdisp.jl
file and executejulia vdisp.jl
:The output file should look like this after running: