Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module DisplacementBehaviour.jl #45

Merged
merged 9 commits into from
May 17, 2022
Merged

Conversation

EmilSoleymani
Copy link
Collaborator

Added DisplacementBehaviour module. As always, to test add the following lines to the body of the vdisp.jl file and execute julia vdisp.jl:

INPUT_DATA_PATH = "../src/.data/input_data.dat"
OUTPUT_DATA_PATH = "../src/.data/output_data.dat"
readInputFile(INPUT_DATA_PATH, OUTPUT_DATA_PATH)

The output file should look like this after running:

Title: Footing IN Granular Soil - Schmertmann
Nodal Points: 17, Base Nodal Point Index: 7
Number of different soil layers: 2
Increment depth(dx): 0.5
Model: CollapsibleSoil
Foundation type: RectangularSlab
Displacements at Each Depth Output

\medskip

% Description
\indentpar In order to verify the validity of the \emph{VDisp} software, we came
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"In order to" should be replaced by "to". I mention this so that you can get out of the habit of using it. 😄 Other low information content phrases can be found in the link given in my writing checklist.

on p.171, there are 4 sample input files along with their respective expected outputs.
We copied these input files, storing them in the directory located at
\href{https://github.com/smiths/vdisp/tree/main/test/.testdata}{\emph{“vdisp/test/.testdata”}}.
We made our \emph{InputParser} module parse each of these files, making sure no errors arose and
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure of the value of using hidden folders to store your test cases?

Copy link
Owner

@smiths smiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep the pull requests focused on one thing. For instance, in the future, the changes to the VnV plan would be better as a separate PR.

What are the instructions for running test cases in julia? I would rather test PRs using the created test cases than the current approach of making temporary changes to vdisp.jl.

The current PR looks good, so I'll accept it. I won't delete the branch though, in case you want to use it to fix the "in order to" issue.

@smiths smiths merged commit b41ef5b into main May 17, 2022
@EmilSoleymani
Copy link
Collaborator Author

EmilSoleymani commented May 17, 2022

In order to run the test cases:

  1. Make sure you are in master directory vdisp/
  2. Execute julia in terminal. The Julia terminal should now come up (with my theme, things are now green).
  3. Type ] to enter Julia's Pkg REPL (with my theme, things are now blue).
  4. Execute activate .
  5. Execute add Test. You should see quite a few dependencies get installed.
  6. Execute test. You should now see the tests running.

Hit backspace to exit from Pkg REPL to Julia terminal. Use Ctrl+D or exit() to exit Julia terminal

@smiths
Copy link
Owner

smiths commented May 17, 2022

The instructions are great. Works fine. I suggest that we create a make file with those instructions and a rule make test. If you don't have time to do it right now, please create an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants