LspLog: one fix, one improvement #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. When the file does not exist the `message` is added to a buffer to eventually be written to the file. When this happens, the `message` is timestamped twice. 2. When println receives an exception, it would be great if the stack trace was printed rather then only the `getMessage`. This commit address these two things
|
Related to the investigation of: #68 |
milesziemer
reviewed
Sep 14, 2022
milesziemer
reviewed
Sep 14, 2022
Co-authored-by: Miles Ziemer <45497130+milesziemer@users.noreply.github.com>
Co-authored-by: Miles Ziemer <45497130+milesziemer@users.noreply.github.com>
|
feel free to squash |
milesziemer
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the file does not exist the
messageis added to a buffer to eventually be written to the file. When this happens, themessageis timestamped twice.When println receives an exception, it would be great if the stack trace was printed rather than only the
getMessage.This commit address these two things