Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signing params debug impl #2562

Merged
merged 3 commits into from
Apr 10, 2023

Conversation

Velfi
Copy link
Contributor

@Velfi Velfi commented Apr 10, 2023

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Velfi Velfi requested a review from a team as a code owner April 10, 2023 18:12
@Velfi Velfi requested a review from a team as a code owner April 10, 2023 18:13
@Velfi Velfi requested review from jdisanti and crisidev April 10, 2023 18:13
CHANGELOG.next.toml Outdated Show resolved Hide resolved
@Velfi Velfi enabled auto-merge April 10, 2023 18:20
@github-actions
Copy link

A new generated diff is ready to view.

  • AWS SDK (ignoring whitespace)
  • No codegen difference in the Client Test
  • No codegen difference in the Server Test
  • No codegen difference in the Server Test Python
  • No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

@Velfi Velfi added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit 33b24bb Apr 10, 2023
@Velfi Velfi deleted the fix/redact-creds-when-debug-logging-signing-params branch April 10, 2023 19:11
Velfi added a commit that referenced this pull request Apr 17, 2023
* fix: redact credentials when debug logging signing params

* update: CHANGELOG.next.toml

* yuki makes a good point
unexge pushed a commit that referenced this pull request Apr 24, 2023
* fix: redact credentials when debug logging signing params

* update: CHANGELOG.next.toml

* yuki makes a good point
rcoh pushed a commit that referenced this pull request Apr 24, 2023
* fix: redact credentials when debug logging signing params

* update: CHANGELOG.next.toml

* yuki makes a good point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants