Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up metadata for release 2023-04-12 #787

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

ysaito1001
Copy link
Collaborator

Motivation and Context

This PR manually removes the aws-smithy-runtime-test crate from versions.toml and ports a CHANGELOG entry from smithy-lang/smithy-rs#2562.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ysaito1001 ysaito1001 requested a review from a team as a code owner April 12, 2023 23:32
@rcoh rcoh merged commit b423775 into main Apr 13, 2023
27 checks passed
rcoh pushed a commit that referenced this pull request Apr 17, 2023
## Motivation and Context
This PR will keep crate versions table in `CHANGELOG.md` in sync with
#768 and
#787.

By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

Co-authored-by: Yuki Saito <awsaito@amazon.com>
ysaito1001 added a commit to smithy-lang/smithy-rs that referenced this pull request Apr 17, 2023
## Motivation and Context
The `aws-smithy-runtime-test` crate has repeatedly caused an issue each
time we released `aws-sdk-rust` from the `smithy-rs-release-0.55.x`
branch. Example PRs for fixing the issue in `aws-sdk-rust` include
- awslabs/aws-sdk-rust#778
- awslabs/aws-sdk-rust#787
- awslabs/aws-sdk-rust#789

This PR will remove the crate in question from the release branch so
that next time we release from `smithy-rs-release-0.55.x`, we do not
need to deal with what's listed above.

The issue only occurs in the `smithy-rs-release-0.55.x` branch, and the
main branch, as of this writing, no longer has it because the crate has
moved from `aws/sdk/integration-tests` to `aws/sra-test`.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Co-authored-by: Yuki Saito <awsaito@amazon.com>
aws-sdk-rust-ci pushed a commit that referenced this pull request May 1, 2023
## Motivation and Context
The `aws-smithy-runtime-test` crate has repeatedly caused an issue each
time we released `aws-sdk-rust` from the `smithy-rs-release-0.55.x`
branch. Example PRs for fixing the issue in `aws-sdk-rust` include
- #778
- #787
- #789

This PR will remove the crate in question from the release branch so
that next time we release from `smithy-rs-release-0.55.x`, we do not
need to deal with what's listed above.

The issue only occurs in the `smithy-rs-release-0.55.x` branch, and the
main branch, as of this writing, no longer has it because the crate has
moved from `aws/sdk/integration-tests` to `aws/sra-test`.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Co-authored-by: Yuki Saito <awsaito@amazon.com>
@jdisanti jdisanti deleted the ysaito/fix-up-release-2023-04-12 branch February 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants