validate required input query params (#646)

smithy-lang · Nov 22, 2022 · 959146f · 959146f
1 parent dfd9b20
commit 959146f
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java b/...a/software/amazon/smithy/typescript/codegen/integration/HttpBindingProtocolGenerator.java
@@ -856,17 +856,21 @@ private void writeRequestQueryParam(
             target
         );
 
+        boolean isRequired = binding.getMember().isRequired();
+        writer.addImport("expectNonNull", "__expectNonNull", "@aws-sdk/smithy-client");
+        String value = isRequired ? "__expectNonNull($L, `" + memberName + "`)" : "$L";
+
         if (Objects.equals("input." + memberName + "!", queryValue)) {
             // simple undefined check
             writer.write(
-                "$S: [,$L],",
+                "$S: [," + value + "],",
                 binding.getLocationName(),
                 queryValue
             );
         } else {
             // undefined check with lazy eval
             writer.write(
-                "$S: [() => input.$L !== void 0, () => $L],",
+                "$S: [() => input.$L !== void 0, () => " + value + "],",
                 binding.getLocationName(),
                 memberName,
                 queryValue