Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate required input query params #646

Merged
merged 1 commit into from Nov 22, 2022
Merged

validate required input query params #646

merged 1 commit into from Nov 22, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 22, 2022

internal JS-3645

expectNonNull is a throwing assertion function from smithy-client.
This PR adds this assertion to input shape members that have the required trait.

Example:

s3.abortMultiPartUpload({ /* missing uploadid */ });
// TypeError: Expected a non-null value for UploadId

@kuhe kuhe requested a review from a team as a code owner November 22, 2022 16:40
@kuhe kuhe mentioned this pull request Nov 22, 2022
Merged
@kuhe kuhe merged commit 959146f into smithy-lang:main Nov 22, 2022
@kuhe kuhe mentioned this pull request Nov 23, 2022
Merged
milesziemer pushed a commit to milesziemer/smithy-typescript that referenced this pull request Dec 14, 2022
@kuhe @milesziemer
validate required input query params (smithy-lang#646)
64622b1
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
@kuhe @srchase
validate required input query params (smithy-lang#646)
077aab7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuhe @trivikr