add script for enforcing pkg json standards #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/pkg-json-enforcement
branch
3 times, most recently
from
9bea73c
to
54ab944
Compare
syall
approved these changes
Nov 9, 2023
kuhe
force-pushed
the
chore/pkg-json-enforcement
branch
2 times, most recently
from
a7ef54e
to
9a574e6
Compare
kuhe
commented
Nov 9, 2023
| @@ -55,6 +55,9 @@ | |||
| "react-native": { | |||
| "@smithy/chunked-blob-reader": "@smithy/chunked-blob-reader-native" | |||
| }, | |||
| "browser": { | |||
| "@smithy/chunked-blob-reader": "@smithy/chunked-blob-reader" | |||
There was a problem hiding this comment.
this is redundant, but much easier to validate
kuhe
force-pushed
the
chore/pkg-json-enforcement
branch
3 times, most recently
from
00bef1a
to
b374742
Compare
kuhe
force-pushed
the
chore/pkg-json-enforcement
branch
from
b374742
to
f4edad0
Compare
trivikr
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pre-commit hook to audit the pkg json bundler directives.
Specifically, we don't know if a bundler is going to use the CJS or ES entrypoint, and thus the file replacement directives should account for either case.