Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new typed properties for trait code generation #2254

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

hpmellema
Copy link
Contributor

Background

Updates trait code generation to use the new typed properties added in PR #2248.

This PR also:

  1. fixes an error in the original PR for typed properties where properties were not added in the toBuilder method
  2. Moves handling of the uniqueItems trait from an integration to the symbol provider.

Testing

  • Ran existing unit and integration tests.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hpmellema hpmellema requested a review from a team as a code owner April 22, 2024 15:03
@JordonPhillips JordonPhillips merged commit aab0a8a into smithy-lang:main Apr 22, 2024
13 checks passed
@hpmellema hpmellema deleted the use-updated-properties branch April 22, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants