Add IDL serializer option to coerce inline IO #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kstich
commented
Jun 11, 2024
| @@ -833,7 +874,7 @@ private Collection<MemberShape> writeInlineableProperty(String key, ShapeId shap | |||
| } | |||
|
|
|||
| private boolean hasOnlyDefaultTrait(Shape shape, ShapeId defaultTrait) { | |||
| return shape.getAllTraits().size() == 1 && shape.hasTrait(defaultTrait); | |||
| return shape.getAllTraits().isEmpty() || (shape.getAllTraits().size() == 1 && shape.hasTrait(defaultTrait)); | |||
There was a problem hiding this comment.
This is the aforementioned fix.
sugmanue
approved these changes
Jun 11, 2024
syall
reviewed
Jun 11, 2024
...est/resources/software/amazon/smithy/model/shapes/idl-serialization/coerced-io/before.smithy
Show resolved
Hide resolved
This commit adds a new IDL serializer configuration, coerceInlineIo, that will use inline IO to write input and output shapes that are only bound to one operation - even if they don't have the input or output trait applied. It also fixes a bug where an empty newline was written before empty inline IO shape definitions.
kstich
force-pushed
the
coerce_inline_io_idl_serializer
branch
from
31b4e10
to
1b901f5
Compare
milesziemer
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new IDL serializer configuration, coerceInlineIo, that will use inline IO to write input and output shapes that are only bound to one operation - even if they don't have the input or output trait applied.
It also fixes a bug where an empty newline was written before empty inline IO shape definitions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.