Fix ec2Query request ID names #2329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
reviewed
Jun 17, 2024
| @@ -47,7 +47,7 @@ apply GreetingWithErrors @httpResponseTests([ | |||
| body: """ | |||
| <GreetingWithErrorsResponse xmlns="https://example.com/"> | |||
| <greeting>Hello</greeting> | |||
| <RequestId>requestid</RequestId> | |||
| <RequestID>requestid</RequestID> | |||
There was a problem hiding this comment.
nit - Should this be requestId if it's a successful response.
kstich
force-pushed
the
ec2Query_request_id_fix
branch
from
a5b5696
to
44196e9
Compare
jonathan343
approved these changes
Jun 17, 2024
JordonPhillips
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aligns with EC2 specs:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.