Switch bit weights between Special and Speed stats #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinXII
reviewed
Dec 18, 2017
js/shared_controls.js
Outdated
| @@ -85,8 +85,8 @@ $(".sl .dvs").keyup(function () { | |||
| function getHPDVs(poke) { | |||
| return (~~poke.find(".at .dvs").val() % 2) * 8 + | |||
| (~~poke.find(".df .dvs").val() % 2) * 4 + | |||
| (~~poke.find(gen === 1 ? ".sl .dvs" : ".sa .dvs").val() % 2) * 2 + | |||
| (~~poke.find(".sp .dvs").val() % 2); | |||
| (~~poke.find(".sp .dvs").val() % 2) * 2 + | |||
There was a problem hiding this comment.
Maybe good enough if I put them all in one line, so it doesn't end up like the first recovery text PR (messy indenting everywhere) ?
|
Hmm guess it’s not so easy on mobile, if you can’t fix it, I’ll fix it for you when I test it. You should be able to highlight white space with your mouse highlighter in case you weren’t aware. |
|
Looks way better now. |
|
So, what now ? |
|
Gotta fix the spacing for this and I’m going to give sadisticmystic a bit more time to verify his issue is fixed |
|
That works. |
|
ugh annoying, but fixed lol. Also thanks for the confirmation @SadisticMystic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #182.. I guess.
In short : instead of considering 2 bits for Special and one for Speed, the Speed DVs affect 2 units of HP DVs, while the Special ones do not affect but one.