Add support of special properties of GMax moves #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Looks good so far! I've marked this as in-progress on the master bug listing our missing Dynamax features. Thanks for taking this on! :) |
|
Hey @yghdj, do you need any help here? :) |
|
Hey, sorry I've been quite busy lately and didn't have much time to wrap this up. I'm having a free day tomorrow so I'll try to work on this. |
|
No rush at all, just wanted to make sure you weren't stuck on something! |
yghdj
force-pushed
the
Add_GMax_EOT_effects
branch
from
4401b39
to
8705c3a
Compare
|
I think everything is covered so far, might add another button for Centiferno/SandTomb since those effects continue for 4 turns even if the Pokemon is switched out. |
yghdj
changed the title
|
Great! Thanks for taking this on! |
|
FYI: I will deploy these 2 changes tomorrow with the monthly sets update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to implement the special EOT effects caused by various G-Max Moves, namely:
For now, only the Wildfire effect is implemented, and using G-Max Wildfire doesn't activate it yet.