Improve npm test: lint
#1525
Improve npm test: lint
#1525
Conversation
|
Ugh... spalger/gulp-jshint#88 |
|
Hmm, if we are fine with the tag-specific dependency here, I might as well add a sane JSCS reporter. |
| "gulp": "~3.8.7", | ||
| "gulp-jshint": "~1.9.2", | ||
| "gulp-jscs": "~1.3.1", | ||
| "gulp-jshint": "git://github.com/spalger/gulp-jshint#c18df3a11", |
There was a problem hiding this comment.
um, I'm not sure how I feel about tracking an unmaintained fork...
There was a problem hiding this comment.
It's actually just a single commit on top of the main repository, but we can let this PR stale until this feature -or an equivalent feature- gets released.
There was a problem hiding this comment.
Are your other changes good, or do they all depend on this?
There was a problem hiding this comment.
39ad898 depends on it... I guess I should take it out and add it later?
There was a problem hiding this comment.
Feel free to do it however you think would be best.
There was a problem hiding this comment.
Ok, did otherwise.
- JSCS rule "disallowNewLineBeforeBlockStatements" is already in Google preset. - JSHint rule "immed" is deprecated in favor of JSCS' "requireParenthesesAroundIIFE". - JSHint rule "smarttabs" is deprecated in favor of JSCS' "disallowMixedSpacesAndTabs": "smart". - JSHint rule "trailing" is deprecated in favor of JSCS' "disallowTrailingWhiteSpace". - JSHint rule "newcap" is deprecated in favor of JSCS' "requireCapitalizedConstructors".
- Use an ES6 parser. - Disallow "with". - Only validate line breaks when running in CI environments. - Add various missing rules regarding spacing and line breaks.
- Streams are merged to make sure that all errors and warnings are reported. - Adds dev dependencies: `merge-stream` and `lazypipe`. - Tracks a fork of `gulp-jshint` to fix spalger/gulp-jshint#88
- Remove `gulp-util`: it's not used and its installation is no longer recommended in Gulp's documentation. - Next minor version for `gulp-jscs`. Next major for `jshint-stylish`.
No description provided.