Dev mode #99
Merged
Dev mode #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dify window hiding function with manual flag, feat(index.js) add double-click on tray for quicker open.
|
v nice notes in this pr, tells me waht to look for opening the menubar via clicking the thing is now broken
|
swyxio
reviewed
Jul 31, 2023
Comment on lines
+304
to
+306
| tray.on('double-click', () => { | ||
| quickOpen(); | ||
| }); |
There was a problem hiding this comment.
did this break the click open?
i think this completes our transition away from a menubar app towards just a straight up full app that happens to have a keyboard shortcut to activate
swyxio
reviewed
Jul 31, 2023
Comment on lines
-385
to
-391
| if (process.platform == 'darwin') { | ||
| // restore focus to previous app on hiding | ||
| mb.on('after-hide', () => { | ||
| mb.app.hide(); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
i think this completes our transition away from a menubar app towards just a straight up full app that happens to have a keyboard shortcut to activate
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better version of "dev mode":