Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.0 #66

Merged
merged 1 commit into from
Apr 26, 2024
Merged

v2.5.0 #66

merged 1 commit into from
Apr 26, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Apr 5, 2024

@notgull notgull requested a review from taiki-e April 5, 2024 16:12
Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Member Author

notgull commented Apr 14, 2024

Added #67 to this

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 14, 2024

(I don't have time right now and will review the actual changes next weekend.)

@notgull
Copy link
Member Author

notgull commented Apr 14, 2024

Thank you @taiki-e! I appreciate your insight!

(I don't have time right now and will review the actual changes next weekend.)

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

cc #50

@taiki-e
Copy link
Collaborator

taiki-e commented Apr 22, 2024

(reviewed #58 (review))

Would replacing concurrent-queue's implementation with one based on crossbeam-queue be appreciated from this perspective? This way there's only one queue implementation to review.

Yeah, I would like to eventually merge them...

@notgull notgull merged commit e874f70 into master Apr 26, 2024
9 checks passed
@notgull notgull deleted the notgull/next branch April 26, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants